linux-kernel - Re: [PATCH] edac: Remove fixmes in e7xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874my98p6u.fsf@nemi.mork.no>
Date:	Tue, 22 Jul 2014 16:04:41 +0200
From:	Bjørn Mork <bjorn@...k.no>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	dougthompson@...ssion.com, bp@...en8.de, m.chehab@...sung.com,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] edac: Remove fixmes in e7xxx_edac.c

Nicholas Krause <xerofoify@...il.com> writes:

> This removes two Page shift fixs me in this file and not checking
> if row is -1 in process_ce as it cannot be this value or be must
> exit this function by returning.
>
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/edac/e7xxx_edac.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/edac/e7xxx_edac.c b/drivers/edac/e7xxx_edac.c
> index 3cda79b..563983f 100644
> --- a/drivers/edac/e7xxx_edac.c
> +++ b/drivers/edac/e7xxx_edac.c
> @@ -211,12 +211,13 @@ static void process_ce(struct mem_ctl_info *mci, struct e7xxx_error_info *info)
>  	edac_dbg(3, "\n");
>  	/* read the error address */
>  	error_1b = info->dram_celog_add;
> -	/* FIXME - should use PAGE_SHIFT */
> -	page = error_1b >> 6;	/* convert the address to 4k page */
> +	page = error_1b >> PAGE_SHIFT;	/* convert the address to 4k page */

I just have to bite...  Where did you get the idea that you can go
around and "fix" FIMXE's like they were spelling errors?


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/