linux-kernel - Re: [PATCH] mfd: max8925-i2c: Add some blank lines before return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140722140631.GG16065@lee--X1>
Date:	Tue, 22 Jul 2014 15:06:31 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	pramod.gurav.etc@...il.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: max8925-i2c: Add some blank lines before return

On Tue, 22 Jul 2014, pramod.gurav.etc@...il.com wrote:

> From: Pramod Gurav <pramod.gurav.etc@...il.com>
> 
> Signed-off-by: Pramod Gurav <pramod.gurav.etc@...il.com>
> ---
> Lee, This is what I was referring to when I said there are more such
> changes needed. Hope they are ok.
> 
> Sending just to you as I could not send it on that mail chain.

I can't accept any patch which hasn't been on the list.  Please find a
way to do so.

> Please add these with your changes if ok.
> 
>  drivers/mfd/max8925-i2c.c |    5 +++++
>  1 file changed, 5 insertions(+)

Can you rebase this on top of my for-mfd-next branc please?

> diff --git a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c
> index a83eed5..d085cdf 100644
> --- a/drivers/mfd/max8925-i2c.c
> +++ b/drivers/mfd/max8925-i2c.c
> @@ -31,6 +31,7 @@ static inline int max8925_read_device(struct i2c_client *i2c,
>  			return ret;
>  		*(unsigned char *)dest = (unsigned char)ret;
>  	}
> +
>  	return ret;
>  }
>  
> @@ -46,6 +47,7 @@ static inline int max8925_write_device(struct i2c_client *i2c,
>  	ret = i2c_master_send(i2c, buf, bytes + 1);
>  	if (ret < 0)
>  		return ret;
> +
>  	return 0;
>  }
>  
> @@ -145,6 +147,7 @@ static int max8925_dt_init(struct device_node *np, struct device *dev,
>  		dev_err(dev, "Not found maxim,tsc-irq property\n");
>  		return -EINVAL;
>  	}
> +
>  	return 0;
>  }
>  
> @@ -220,6 +223,7 @@ static int max8925_suspend(struct device *dev)
>  
>  	if (device_may_wakeup(dev) && chip->wakeup_flag)
>  		enable_irq_wake(chip->core_irq);
> +
>  	return 0;
>  }
>  
> @@ -230,6 +234,7 @@ static int max8925_resume(struct device *dev)
>  
>  	if (device_may_wakeup(dev) && chip->wakeup_flag)
>  		disable_irq_wake(chip->core_irq);
> +
>  	return 0;
>  }
>  #endif

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/