linux-kernel - Re: [PATCH] staging: llite: rw.c: use gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140722020805.GA19215@kroah.com>
Date:	Mon, 21 Jul 2014 19:08:05 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Guillaume Morin <guillaume@...infr.org>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	oleg.drokin@...el.com, jinshan.xiong@...el.com,
	lai.siyao@...el.com, joe@...ches.com, bergwolf@...il.com,
	john.hammond@...el.com, sachin.kamat@...aro.org
Subject: Re: [PATCH] staging: llite: rw.c: use gfp_t to store GFP flags

On Tue, Jul 22, 2014 at 02:57:57AM +0200, Guillaume Morin wrote:
> Use gfp_t to store GPF_* flags instead of unsigned int. 
> This was reported by sparse.
> 
> Signed-off-by: Guillaume Morin <guillaume@...infr.org>
> ---
>  drivers/staging/lustre/lustre/llite/rw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/rw.c b/drivers/staging/lustre/lustre/llite/rw.c
> index 5616210..3554272 100644
> --- a/drivers/staging/lustre/lustre/llite/rw.c
> +++ b/drivers/staging/lustre/lustre/llite/rw.c
> @@ -496,7 +496,7 @@ static int ll_read_ahead_page(const struct lu_env *env, struct cl_io *io,
>  	struct cl_object *clob  = ll_i2info(mapping->host)->lli_clob;
>  	struct cl_page   *page;
>  	enum ra_stat      which = _NR_RA_STAT; /* keep gcc happy */
> -	unsigned int      gfp_mask;
> +	gfp_t             gfp_mask;

Odd thing is, that function doesn't seem to even use that variable
anywhere...  Can you just remove it entirely?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/