linux-kernel - Re: [PATCH] pinctrl: qcom: Make muxing of gpio function explicit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZr6sWNW3Jb2zSmjyLP0h-0b32966f_NQiAE_s17DKFxQ@mail.gmail.com>
Date:	Tue, 22 Jul 2014 16:33:07 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Bjorn Andersson <bjorn.andersson@...ymobile.com>
Cc:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: qcom: Make muxing of gpio function explicit

On Sat, Jul 12, 2014 at 3:21 AM, Bjorn Andersson
<bjorn.andersson@...ymobile.com> wrote:

> Instead of relying on pinmux->disable(), make the gpio function an
> explicit function for all pins that supports it.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...ymobile.com>

Thanks, patch applied!

> This fixes the regression that was introduced by removing the disable function
> from the pinmux ops. I was exploiting the disable function to put the gpio pins
> "back" into gpio state and this was apparently not the right way to do things.

This is so much cleaner I think.

Please proceed to patch your DTS files for this as needed.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/