lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPDOMVjaf+vne4vbUPo8EPs0XnQBbNm2ZOXns8fw5pkg9tRSww@mail.gmail.com> Date: Tue, 22 Jul 2014 13:40:42 -0400 From: Nick Krause <xerofoify@...il.com> To: Tony Luck <tony.luck@...il.com> Cc: Bjørn Mork <bjorn@...k.no>, Doug Thompson <dougthompson@...ssion.com>, Borislav Petkov <bp@...en8.de>, "m.chehab@...sung.com" <m.chehab@...sung.com>, Linux Edac Mailing List <linux-edac@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] edac: Remove fixmes in e7xxx_edac.c On Tue, Jul 22, 2014 at 1:25 PM, Tony Luck <tony.luck@...il.com> wrote: > On Tue, Jul 22, 2014 at 7:04 AM, Bjørn Mork <bjorn@...k.no> wrote: >>> - /* FIXME - should use PAGE_SHIFT */ >>> - page = error_1b >> 6; /* convert the address to 4k page */ >>> + page = error_1b >> PAGE_SHIFT; /* convert the address to 4k page */ >> >> I just have to bite... Where did you get the idea that you can go >> around and "fix" FIMXE's like they were spelling errors? > > Or apparently without thinking? Since "PAGE_SHIFT" does not have > the numerical value "6" your new code is obviously not equivalent to > the old. > > -Tony Tony, What is the value of Page shift then ? If you can tell me it would be much easier for me to fix this. Cheers Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists