lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1406056988.2755.1.camel@joe-AO725> Date: Tue, 22 Jul 2014 12:23:08 -0700 From: Joe Perches <joe@...ches.com> To: Hartley Sweeten <HartleyS@...ionengravers.com> Cc: Andy Whitcroft <apw@...onical.com>, LKML <linux-kernel@...r.kernel.org> Subject: Re: checkpatch.pl false positive On Tue, 2014-07-22 at 17:30 +0000, Hartley Sweeten wrote: > Joe, > > I think this is a false positive, at least the check message appears > incorrect: > > CHECK: No space is necessary after a cast > #66: FILE: arch/arm/mach-ep93xx/include/mach/platform.h:66: > +static inline int crunch_init(void) { return 0; } Yeah, it's a false positive introduced by -next commit 89da401f6cff ("checkpatch: improve "no space after cast" test") Try this? --- diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2258497..644c2d5 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2418,7 +2418,7 @@ sub process { } } - if ($line =~ /^\+.*\(\s*$Type\s*\)[ \t]+(?!$Assignment|$Arithmetic)/) { + if ($line =~ /^\+.*\(\s*$Type\s*\)[ \t]+(?!$Assignment|$Arithmetic|{)/) { if (CHK("SPACING", "No space is necessary after a cast\n" . $herecurr) && $fix) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists