linux-kernel - Re: [PATCH] edac: Remove fixmes in e7xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Jul 2014 16:56:06 -0400
From:	Nick Krause <xerofoify@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Levente Kurusa <lkurusa@...hat.com>,
	Tony Luck <tony.luck@...il.com>,
	Bjørn Mork <bjorn@...k.no>,
	Doug Thompson <dougthompson@...ssion.com>,
	Borislav Petkov <bp@...en8.de>,
	"m.chehab@...sung.com" <m.chehab@...sung.com>,
	Linux Edac Mailing List <linux-edac@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] edac: Remove fixmes in e7xxx_edac.c

On Tue, Jul 22, 2014 at 3:33 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Tue, Jul 22, 2014 at 02:25:24PM -0400, Nick Krause wrote:
>>
>> I understand what your saying and I should have searched for Page shift.
>> In addition I am already got commits in the kernel for fix mes so I feel
>> that your comment on fix mes is incorrect.
>
> After seeing your other solutions to "fix mes" around the kernel, I now have to
> investigate the patches that were accepted, and see if they did not cause
> any new bugs. If any of them do, I will ask to have all your patches reverted.
>
> You are not helping. You are actually doing quite the opposite. Who do you work
> for? Microsoft or Apple?
>
> -- Steve
>

I don't work for any companies. And here is one of them that has been accepted.
I am removing two fix mes in this file as after dicussing then it  seems
there is no reason to check against Null for usb_device as it can never
be NULL and this is check is therefore not needed.

Signed-off-by: Nicholas Krause <xerofoify@...il.com>
---
 drivers/usb/core/hcd.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index bec31e2..487abcf 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -855,8 +855,6 @@ static ssize_t authorized_default_show(struct device *dev,
        struct usb_bus *usb_bus = rh_usb_dev->bus;
        struct usb_hcd *usb_hcd;

-       if (usb_bus == NULL)    /* FIXME: not sure if this case is possible */
-               return -ENODEV;
        usb_hcd = bus_to_hcd(usb_bus);
        return snprintf(buf, PAGE_SIZE, "%u\n", usb_hcd->authorized_default);
 }
@@ -871,8 +869,6 @@ static ssize_t authorized_default_store(
struct device *dev,
        struct usb_bus *usb_bus = rh_usb_dev->bus;
        struct usb_hcd *usb_hcd;

-       if (usb_bus == NULL)    /* FIXME: not sure if this case is possible */
-               return -ENODEV;
        usb_hcd = bus_to_hcd(usb_bus);
        result = sscanf(buf, "%u\n", &val);
        if (result == 1) {
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/