lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPDOMVj4Rg7YyfErabfAuGdbJG7Owbh3k8AGgTVODcb1jfTGuQ@mail.gmail.com> Date: Tue, 22 Jul 2014 18:08:44 -0400 From: Nick Krause <xerofoify@...il.com> To: David Rientjes <rientjes@...gle.com> Cc: Thomas Gleixner <tglx@...utronix.de>, mingo@...hat.com, hpa@...or.com, x86@...nel.org, gleb@...nel.org, pbonzini@...hat.com, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, kvm@...r.kernel.org Subject: Re: [PATCH] x86: Remove Fix me in main.c and add include statement for kvm_para.h On Tue, Jul 22, 2014 at 6:06 PM, David Rientjes <rientjes@...gle.com> wrote: > On Tue, 22 Jul 2014, Nicholas Krause wrote: > >> This patch removes a fix me by including linux/types.h in kvm_para.h >> as stated by the fix me in main.c and also removes the comment from >> main.c too. >> >> Signed-off-by: Nicholas Krause <xerofoify@...il.com> >> --- >> arch/x86/kernel/cpu/mtrr/main.c | 2 +- >> include/linux/kvm_para.h | 3 +-- >> 2 files changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c >> index f961de9..7ba314b 100644 >> --- a/arch/x86/kernel/cpu/mtrr/main.c >> +++ b/arch/x86/kernel/cpu/mtrr/main.c >> @@ -33,7 +33,7 @@ >> >> #define DEBUG >> >> -#include <linux/types.h> /* FIXME: kvm_para.h needs this */ >> +#include <linux/types.h> >> >> #include <linux/stop_machine.h> >> #include <linux/kvm_para.h> >> diff --git a/include/linux/kvm_para.h b/include/linux/kvm_para.h >> index 00a97bb..21d1be2 100644 >> --- a/include/linux/kvm_para.h >> +++ b/include/linux/kvm_para.h >> @@ -2,8 +2,7 @@ >> #define __LINUX_KVM_PARA_H >> >> #include <uapi/linux/kvm_para.h> >> - >> - >> +#include <linux/types.h> >> static inline int kvm_para_has_feature(unsigned int feature) >> { >> if (kvm_arch_para_features() & (1UL << feature)) > > There's no build error reported that would indicate that this is needed, > so this patch isn't justifiable. David, Good to hear a nicer reply after my stupid patch with page shifts. Would you like me to send in a patch that removes this fix me then? Nick :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists