linux-kernel - Re: [PATCH] cleanup include/asm-generic/atomic.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1407221515010.5814@chino.kir.corp.google.com>
Date:	Tue, 22 Jul 2014 15:17:05 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>
cc:	arnd@...db.de, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cleanup include/asm-generic/atomic.h

On Tue, 22 Jul 2014, Madhavan Srinivasan wrote:

> On Tuesday 22 July 2014 05:38 AM, David Rientjes wrote:
> > On Tue, 22 Jul 2014, Madhavan Srinivasan wrote:
> > 
> >> Commit 4b358e2206 "cleanup include/asm-generic/atomic.h" added
> >> comments for #else/#endif, but ended up adding same comment
> >> "BITS_PER_LONG == 64" on both sides. This patch fixes it.
> >>
> > 
> > It's intentionally like that, it comments the condition for which the 
> > #endif is matched.
> 
> Ok, will change the else comment. And include/asm-generic/local64.h
> also needs a change in comment.
> 

The #else comment is fine, it's correct as written.  The only use of these 
comments is to identify for the reader the #ifdef for which it is matched 
when there at least one nested #ifdef.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/