lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 23 Jul 2014 09:26:30 +0800
From:	Lai Jiangshan <laijs@...fujitsu.com>
To:	Tejun Heo <tj@...nel.org>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] workqueue: get the probable node ID from the first CPU
 of the mask

On 07/22/2014 11:30 PM, Tejun Heo wrote:
> On Tue, Jul 22, 2014 at 01:04:02PM +0800, Lai Jiangshan wrote:
>> +		node = cpu_to_node(cpumask_first(pool->attrs->cpumask));
> 
> Minor but maybe cpumask_any() is a better fit here?
> 

It is OK, the result are the same. But I still think cpumask_first() is better since
its name sounds deterministic while we need a deterministic value for pool->node.

Thanks,
Lai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists