linux-kernel - Re: [PATCH v2 3/4] virtio: rng: delay hwrng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8761iozkq6.fsf@rustcorp.com.au>
Date:	Wed, 23 Jul 2014 15:21:13 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Amit Shah <amit.shah@...hat.com>, linux-kernel@...r.kernel.org
Cc:	Virtualization List <virtualization@...ts.linux-foundation.org>,
	herbert@...dor.apana.org.au, keescook@...omium.org,
	jason@...edaemon.net, Amos Kong <akong@...hat.com>
Subject: Re: [PATCH v2 3/4] virtio: rng: delay hwrng_register() till driver is ready

Amit Shah <amit.shah@...hat.com> writes:
> On (Mon) 21 Jul 2014 [17:15:51], Amit Shah wrote:
>> Instead of calling hwrng_register() in the probe routing, call it in the
>> scan routine.  This ensures that when hwrng_register() is successful,
>> and it requests a few random bytes to seed the kernel's pool at init,
>> we're ready to service that request.
>> 
>> This will also enable us to remove the workaround added previously to
>> check whether probe was completed, and only then ask for data from the
>> host.  The revert follows in the next commit.
>> 
>> There's a slight behaviour change here on unsuccessful hwrng_register().
>> Previously, when hwrng_unregister() failed, the probe() routine would
>
> typo: should be hwrng_register().
>
> Please fix this up when picking up the patch.

Done.

All 4 patches applied!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/