linux-kernel - Re: [PATCH 1/4] usb: move the OTG state from the USB PHY to the OTG structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140723070831.GA10816@kwain>
Date:	Wed, 23 Jul 2014 09:08:31 +0200
From:	Antoine Ténart 
	<antoine.tenart@...e-electrons.com>
To:	Bin Liu <binmlist@...il.com>
Cc:	Antoine Ténart 
	<antoine.tenart@...e-electrons.com>, balbi@...com,
	gregkh@...uxfoundation.org, Peter.Chen@...escale.com,
	kishon@...com, stern@...land.harvard.edu,
	alexandre.belloni@...e-electrons.com,
	thomas.petazzoni@...e-electrons.com, zmxu@...vell.com,
	jszhang@...vell.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] usb: move the OTG state from the USB PHY to the OTG
 structure

Hi,

On Tue, Jul 22, 2014 at 04:33:54PM -0500, Bin Liu wrote:
> On Wed, Jul 9, 2014 at 5:17 AM, Antoine Ténart
> <antoine.tenart@...e-electrons.com> wrote:
> > diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
> > index 7cccab6ff308..9a9702773e43 100644
> > --- a/drivers/usb/chipidea/debug.c
> > +++ b/drivers/usb/chipidea/debug.c
> > @@ -219,8 +219,7 @@ int ci_otg_show(struct seq_file *s, void *unused)
> >         fsm = &ci->fsm;
> >
> >         /* ------ State ----- */
> > -       seq_printf(s, "OTG state: %s\n\n",
> 
> Is this line removed by accident?
> 
> > -               usb_otg_state_string(ci->transceiver->state));
> > +               usb_otg_state_string(ci->transceiver->otg.state));
> >
> >         /* ------ State Machine Variables ----- */

It is. I'll fix this.

Thanks!

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/