linux-kernel - Re: linux-next: build warnings after merge of the gpio tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdb=NgzC=1i96pbuHpUh+S9=6Jv+F1AQit+xf3CJf2q+tA@mail.gmail.com>
Date:	Wed, 23 Jul 2014 10:46:49 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	abdoulaye berthe <berthe.ab@...il.com>
Subject: Re: linux-next: build warnings after merge of the gpio tree

On Wed, Jul 23, 2014 at 10:45 AM, Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> After merging the gpio tree, today's linux-next build (powerpc
> allyesconfig) produced these warnings:
>
> drivers/gpio/gpio-ucb1400.c: In function 'ucb1400_gpio_remove':
> drivers/gpio/gpio-ucb1400.c:92:2: warning: ignoring return value of 'gpiochip_remove', declared with attribute warn_unused_result [-Wunused-result]
>   gpiochip_remove(&ucb->gc);
>   ^
>
> And lots of similar ones.
>
> Introduced by commit 9f5132ae82fd ("gpio: remove all usage of
> gpio_remove retval in driver/gpio").

Yes we're planning to get rid of the retval in the next merge window after first
purging all drivers.

> Maybe the __must_check attribute should be removed from the declaration
> of the function before removing the retval checking ...

Hey, good idea. I'll do this.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/