linux-kernel - Re: [PATCH] drivers/crypto/Kconfig: Let 'DEV_QCE' depend on both HAS_DMA and HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Jul 2014 19:43:00 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	herbert@...dor.apana.org.au
CC:	davem@...emloft.net, linux-crypto@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Liqin Chen <liqin.linux@...il.com>,
	Lennox Wu <lennox.wu@...il.com>
Subject: Re: [PATCH] drivers/crypto/Kconfig: Let 'DEV_QCE' depend on both
 HAS_DMA and HAS_IOMEM

Oh, sorry, this patch can still be alive, after a long discussion, we
need keep current status no touch -- still let individual modules to
depends on HAS_IOMEM and/or HAS_DMA, if they need them.

So please help check the patch, when you have time.

Thanks.

On 07/14/2014 08:12 PM, Chen Gang wrote:
> Hello all:
> 
> This patch is obsoleted according to the other discussion thread about
> IOMEM and COMPILE_TEST.
> 
> I shall fix it, and maybe not need touch drivers/crypto again, so maybe
> not need send patch v2 for it.
> 
> Thanks.
> 
> On 07/13/2014 11:01 AM, Chen Gang wrote:
>> 'DEV_QCE' needs both HAS_DMA and HAS_IOMEM, so let it depend on them.
>>
>> The related error (with allmodconfig under score):
>>
>>     MODPOST 1365 modules
>>   ERROR: "devm_ioremap_resource" [drivers/crypto/qce/qcrypto.ko] undefined!
>>   ERROR: "dma_map_sg" [drivers/crypto/qce/qcrypto.ko] undefined!
>>   ERROR: "dma_set_mask" [drivers/crypto/qce/qcrypto.ko] undefined!
>>   ERROR: "dma_supported" [drivers/crypto/qce/qcrypto.ko] undefined!
>>   ERROR: "dma_unmap_sg" [drivers/crypto/qce/qcrypto.ko] undefined!
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
>> ---
>>  drivers/crypto/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
>> index 5ef9ec9..2fb0fdf 100644
>> --- a/drivers/crypto/Kconfig
>> +++ b/drivers/crypto/Kconfig
>> @@ -422,7 +422,7 @@ source "drivers/crypto/qat/Kconfig"
>>  
>>  config CRYPTO_DEV_QCE
>>  	tristate "Qualcomm crypto engine accelerator"
>> -	depends on ARCH_QCOM || COMPILE_TEST
>> +	depends on (ARCH_QCOM || COMPILE_TEST) && HAS_DMA && HAS_IOMEM
>>  	select CRYPTO_AES
>>  	select CRYPTO_DES
>>  	select CRYPTO_ECB
>>
> 

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/