linux-kernel - Re: [patch] checkpatch: warn on missing spaces in broken up quoted strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Jul 2014 14:56:47 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: Re: [patch] checkpatch: warn on missing spaces in broken up quoted
 strings

On Mon, Jun 16, 2014 at 11:27:36AM -0700, Joe Perches wrote:
> > > Likely the \\[a-zA-Z] check should include
> > > all the tests that the multiple line string exceptions use.
> > > 
> > > (?:\\(?:[ntr]|[0-7]{1,3}|x[0-9a-fA-F]{1,2})|;\s*|\{\s*)"\s*$
> > 
> > That kind of complicate regex hurts my head.  How do I make it not
> > complain about:
> > 		"foo\n\t"
> > 		"bar";
> 
> Did you try it?
> 

Of course I tried it...  I certainly am not able to *read* it.  :P
I think that I don't know what you meant?  Just give me a whole patch I
can apply.

I also tested my version against patches and not just whole files and it
seems to work fine.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/