linux-kernel - Re: [PATCH] drbd: Remove fix me statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8738dsi7l7.fsf@nemi.mork.no>
Date:	Wed, 23 Jul 2014 14:27:00 +0200
From:	Bjørn Mork <bjorn@...k.no>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	drbd-dev@...ts.linbit.com, drbd-user@...ts.linbit.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drbd: Remove fix me statements

Nicholas Krause <xerofoify@...il.com> writes:

> This removes no longer needed fix me statements

If you claim that they no longer are needed then I expect you to explain
what's changed since they were added.

> as the spinlocks
> are needed to protect against other users of the list accessing
>  it when items on it are being moved off it.

Yes, that's most likely why the locking is there.

The FIXMEs on the other hand, are probably there to tell you that it
would be nice to get rid of the double locking.  I don't see that
changing.

Bjørn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/