linux-kernel - Re: [PATCH 16/16] rcu: kvm.sh: Fix error when you pass --cpus argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140723123155.GO11241@linux.vnet.ibm.com>
Date:	Wed, 23 Jul 2014 05:31:56 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Pranith Kumar <bobby.prani@...il.com>
Cc:	Josh Triplett <josh@...htriplett.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	"open list:RCUTORTURE TEST F..." <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 16/16] rcu: kvm.sh: Fix error when you pass --cpus
 argument

On Wed, Jul 23, 2014 at 01:09:53AM -0400, Pranith Kumar wrote:
> When you pass --cpus argument to kvm.sh, it errors out as it assumes you have
> all the requires CPUs to run a batch. This commit fixes this along with a minor
> comment fix.
> 
> Signed-off-by: Pranith Kumar <bobby.prani@...il.com>

The current code does what I want, namely allowing you to run tests
in parallel.  If you are running on a system with less than 16 CPUs,
this will of course not work -- and I -want- it to yell at me if I try
a full parallel run on my laptop instead of my lab machine.  One easy
way to work around this is to use the --configs argument to run the big
tests sequentially, then again to run the smaller tests in parallel.
So sorry, but no.

							Thanx, Paul

> ---
>  tools/testing/selftests/rcutorture/bin/kvm.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/rcutorture/bin/kvm.sh b/tools/testing/selftests/rcutorture/bin/kvm.sh
> index 36534f9..1128d85 100755
> --- a/tools/testing/selftests/rcutorture/bin/kvm.sh
> +++ b/tools/testing/selftests/rcutorture/bin/kvm.sh
> @@ -214,7 +214,7 @@ END {
>  	batch = 0;
>  	nc = -1;
> 
> -	# Each pass through the following loop creates on test batch
> +	# Each pass through the following loop creates one test batch
>  	# that can be executed concurrently given ncpus.  Note that a
>  	# given test that requires more than the available CPUs will run in
>  	# their own batch.  Such tests just have to make do with what
> @@ -228,7 +228,7 @@ END {
>  		for (i = 0; i < njobs; i++) {
>  			if (done[i])
>  				continue; # Already part of a batch.
> -			if (nc >= cpus[i] || nc == ncpus) {
> +			if (nc >= cpus[i]) {
> 
>  				# This test fits into the current batch.
>  				done[i] = batch;
> -- 
> 2.0.0.rc2
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/