linux-kernel - Re: [PATCH] power: add driver for battery reading on iPaq h3xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 Jul 2014 14:54:09 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	Dmitry Artamonow <mad_soft@...ox.ru>
Subject: Re: [PATCH] power: add driver for battery reading on iPaq h3xxx

Hi Linus,

On Sat, Jul 12, 2014 at 11:33:49AM +0200, Linus Walleij wrote:
> [...]
> +
> +#define BATT_PERIOD 100000 /* 10 seconds in milliseconds */

that's 100 seconds...

> [...]
> +
> +struct micro_battery {
> +	struct ipaq_micro *micro;
> +	struct workqueue_struct *wq;
> +	struct delayed_work update;
> +	u8 ac;
> +	u8 chemistry;
> +	unsigned int voltage;
> +	u16 temperature;
> +	u8 flag;
> +};
> +
> [...]
> +
> +static struct power_supply micro_battery = {
                              ^^^^^^^^^^^^^
I would prefer to have a name different from the struct defined
above.

> [...]

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)