linux-kernel - Re: [PATCH] m68k/q40: Revert "m68k/q40: Fix q40_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53CFC170.9090505@roeck-us.net>
Date:	Wed, 23 Jul 2014 07:06:40 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Sasha Levin <sasha.levin@...cle.com>, geert@...ux-m68k.org
CC:	rostedt@...dmis.org, gnomes@...rguk.ukuu.org.uk,
	xerofoify@...il.com, linux-m68k@...r.kernel.org,
	linux-kernel@...r.kernel.org, Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH] m68k/q40: Revert "m68k/q40: Fix q40_irq_startup() to
 return -ENXIO on failures"

On 07/23/2014 05:51 AM, Sasha Levin wrote:
> Revert since we're trying to return -ENXIO from a function returning
> unsigned int. Not only it causes compiler warnings it's also obviously
> incorrect.
>
> In general, watch for patches from Nick Krause since they are not even
> build tested.
>
> Signed-off-by: Sasha Levin <sashal@...nel.org>

Guess I wasn't fast enough with my comments :-(

Acked-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   arch/m68k/q40/q40ints.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c
> index 9dfa1ea..513f9bb 100644
> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -49,7 +49,7 @@ static unsigned int q40_irq_startup(struct irq_data *data)
>   	case 1: case 2: case 8: case 9:
>   	case 11: case 12: case 13:
>   		printk("%s: ISA IRQ %d not implemented by HW\n", __func__, irq);
> -		return -ENXIO;
> +		/* FIXME return -ENXIO; */
>   	}
>   	return 0;
>   }
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/