linux-kernel - Re: [PATCH] staging: bcm : Transmit.c : fixed coding style problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140723140840.GU25880@mwanda>
Date:	Wed, 23 Jul 2014 17:08:40 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	sudip <sudipm.mukherjee@...il.com>
Cc:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: bcm : Transmit.c : fixed coding style problem

Subject is too general.  Which coding style issue did you fix?

On Wed, Jul 23, 2014 at 07:22:30PM +0530, sudip wrote:

Use your full name.  "Sudip Mukherjee" not just "sudip".

> applies to next-20140723

Leave this out.

> 
> 
> Signed-off-by: sudip <sudipm.mukherjee@...il.com>

Use your real name again.

> ---
>  drivers/staging/bcm/Transmit.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c
> index 05fae92..10586f8 100644
> --- a/drivers/staging/bcm/Transmit.c
> +++ b/drivers/staging/bcm/Transmit.c
> @@ -89,7 +89,8 @@ int SendControlPacket(struct bcm_mini_adapter *Adapter, char *pControlPacket)
>   * to the target via the host h/w interface.
>   * @return  zero(success) or -ve value(failure)
>   */
> -int SetupNextSend(struct bcm_mini_adapter *Adapter,  struct sk_buff *Packet, USHORT Vcid)
> +int SetupNextSend(struct bcm_mini_adapter *Adapter,
> +		struct sk_buff *Packet, USHORT Vcid)
>  {
>  	int	status = 0;
>  	bool	bHeaderSupressionEnabled = false;
> @@ -205,7 +206,8 @@ int tx_pkt_handler(struct bcm_mini_adapter *Adapter)
>  	int status = 0;
>  
>  	while (!kthread_should_stop()) {
> -		/* FIXME - the timeout looks like workaround for racey usage of TxPktAvail */
> +		/* FIXME - the timeout looks like workaround
> +		   for racey usage of TxPktAvail */

This is not proper style for muti-line comments.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/