linux-kernel - Re: [PATCH] microblaze: Add comment for defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 Jul 2014 07:09:53 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Nicholas Krause <xerofoify@...il.com>, monstr@...str.eu
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] microblaze: Add comment for defines

On 07/22/2014 09:27 PM, Nicholas Krause wrote:
> This adds a comment for and removes a fix me by labeling these
> defines as memory cache definitions.
>
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>   arch/microblaze/include/asm/pvr.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/microblaze/include/asm/pvr.h b/arch/microblaze/include/asm/pvr.h
> index 4bbdb4c..441f3a0 100644
> --- a/arch/microblaze/include/asm/pvr.h
> +++ b/arch/microblaze/include/asm/pvr.h
> @@ -186,7 +186,7 @@ struct pvr_s {
>   #define PVR_DCACHE_USE_FSL(_pvr)	(_pvr.pvr[5] & PVR5_DCACHE_USE_FSL_MASK)
>   #define PVR_DCACHE_ALLOW_WR(_pvr) \
>   			(_pvr.pvr[5] & PVR5_DCACHE_ALLOW_WR_MASK)
> -/* FIXME two shifts on one line needs any comment */
> +/* memory caches */

"two shifts on one line needs any comment"

You are not providing the comment asked for. The FIXME requests a comment explaining
why the double shift is needed, not just a random comment like the one you provided
that doesn't explain anything.

Guenter

>   #define PVR_DCACHE_LINE_LEN(_pvr) \
>   		(1 << ((_pvr.pvr[5] & PVR5_DCACHE_LINE_LEN_MASK) >> 21))
>   #define PVR_DCACHE_BYTE_SIZE(_pvr) \
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/