linux-kernel - Re: [PATCH] drivers: CCI: Correct use of ! and &

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140723150518.GD27677@arm.com>
Date:	Wed, 23 Jul 2014 16:05:18 +0100
From:	Will Deacon <will.deacon@....com>
To:	Punit Agrawal <punit.agrawal@....com>
Cc:	Himangi Saraogi <himangi774@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"julia.lawall@...6.fr" <julia.lawall@...6.fr>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] drivers: CCI: Correct use of ! and &

On Wed, Jul 23, 2014 at 04:01:56PM +0100, Punit Agrawal wrote:
> > diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> > index 5a86da9..7af78df 100644
> > --- a/drivers/bus/arm-cci.c
> > +++ b/drivers/bus/arm-cci.c
> > @@ -397,7 +397,8 @@ static irqreturn_t pmu_handle_irq(int irq_num, void *dev)
> >  		hw_counter = &event->hw;
> >  
> >  		/* Did this counter overflow? */
> > -		if (!pmu_read_register(idx, CCI_PMU_OVRFLW) & CCI_PMU_OVRFLW_FLAG)
> > +		if (!(pmu_read_register(idx, CCI_PMU_OVRFLW) &
> > +		      CCI_PMU_OVRFLW_FLAG))
> >  			continue;
> 
> 
> Going back to the manual, this fix looks correct.
> 
> Acked-by: Punit Agrawal <punit.agrawal@....com>
> 
> Will, would this go via your tree?

Given that you're happy with it, I don't mind which tree it goes in.
Probably deserves a CC stable on it too.

If you get stuck, put it in rmk's patch system.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/