lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Jul 2014 19:11:23 +0300 From: "Ivan T. Ivanov" <iivanov@...sol.com> To: Linus Walleij <linus.walleij@...aro.org> Cc: Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Grant Likely <grant.likely@...aro.org>, Bjorn Andersson <bjorn.andersson@...ymobile.com>, Mark Brown <broonie@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org> Subject: Re: [PATCH v2 2/4] pinctrl: qpnp: Qualcomm PMIC pin controller driver On Wed, 2014-07-23 at 17:27 +0200, Linus Walleij wrote: > On Thu, Jul 17, 2014 at 5:25 PM, Ivan T. Ivanov <iivanov@...sol.com> wrote: > > > From: "Ivan T. Ivanov" <iivanov@...sol.com> > > > > This is the pinctrl, pinmux, pinconf and gpiolib driver for the > > Qualcomm GPIO and MPP sub-function blocks found in the PMIC chips. > > > > Signed-off-by: Ivan T. Ivanov <iivanov@...sol.com> > (...) > > +static int qpnp_pinctrl_remove(struct platform_device *pdev) > > +{ > > + struct qpnp_pinctrl *qctrl = platform_get_drvdata(pdev); > > + > > + pinctrl_unregister(qctrl->ctrl); > > + > > + return gpiochip_remove(&qctrl->chip); > > We're removing the return value from gpiochip_remove() and I > have dropped the __must_check attribute today, so just remove > it unconditionally and return 0; Yes, I know. Patches are based on v3.16-rc6 tag. > > Sorry for short and lame comment on a large patch I should look > closer at, but atleast it's something. Thanks, Ivan > > Yours, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists