linux-kernel - Re: [PATCH libata/for-3.16-fixes] libata: introduce ata_host->n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140723163601.GE7103@htj.dyndns.org>
Date:	Wed, 23 Jul 2014 12:36:01 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:	Jesse Brandeburg <jesse.brandeburg@...il.com>,
	Mike Qiu <qiudayu@...ux.vnet.ibm.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-ide@...r.kernel.org, wenxiong@...ux.vnet.ibm.com,
	brking@...ux.vnet.ibm.com, zhenghch@...ibm.com, haokexin@...il.com,
	Peter Hurley <peter@...leysoftware.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Alexey Kardashevskiy <aik@...abs.ru>
Subject: Re: [PATCH libata/for-3.16-fixes] libata: introduce ata_host->n_tags
 to avoid oops on SAS controllers

Hello,

On Wed, Jul 23, 2014 at 06:31:58PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Hmmm, wasn't ATA_MAX_QUEUE used before not ATA_MAX_QUEUE - 1?
> 
> It seems that after your patch the loop in the ata_qc_new() will use
> only 30 tags and not 31 ones?

It was always 31 (ATA_MAX_QUEUE - 1) with the tag 31 reserved for EH
commands.  The previous patch just used limit value which is one too
high.  I'm planning to change that but this is the way it has always
been.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/