linux-kernel - Re: [PATCH 4/9] fs.h: Add argument names to struct file_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140723135914.0f099e95@tlielax.poochiereds.net>
Date:	Wed, 23 Jul 2014 13:59:14 -0400
From:	Jeff Layton <jlayton@...chiereds.net>
To:	Joe Perches <joe@...ches.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...IV.linux.org.uk>,
	David Teigland <teigland@...hat.com>,
	"J. Bruce Fields" <bfields@...ldses.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/9] fs.h: Add argument names to struct
 file_lock_operations (*funcs)

On Sun, 20 Jul 2014 11:23:38 -0700
Joe Perches <joe@...ches.com> wrote:

> Function pointer struct members without argument type names
> are not very clear.  Add them.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  include/linux/fs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 05be298..65685a7 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -834,8 +834,8 @@ static inline struct file *get_file(struct file *f)
>  typedef void *fl_owner_t;
>  
>  struct file_lock_operations {
> -	void (*fl_copy_lock)(struct file_lock *, struct file_lock *);
> -	void (*fl_release_private)(struct file_lock *);
> +	void (*fl_copy_lock)(struct file_lock *dst, struct file_lock *fl);
> +	void (*fl_release_private)(struct file_lock *fl);
>  };
>  
>  struct lock_manager_operations {

Seems trivial, but ok...

Acked-by: Jeff Layton <jlayton@...chiereds.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/