linux-kernel - Re: [PATCH 8/9] dlm: plock: Reduce indentation by rearranging order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140723140138.4ac10979@tlielax.poochiereds.net>
Date:	Wed, 23 Jul 2014 14:01:38 -0400
From:	Jeff Layton <jlayton@...chiereds.net>
To:	Joe Perches <joe@...ches.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...IV.linux.org.uk>,
	David Teigland <teigland@...hat.com>,
	Christine Caulfield <ccaulfie@...hat.com>,
	cluster-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/9] dlm: plock: Reduce indentation by rearranging order

On Sun, 20 Jul 2014 11:23:42 -0700
Joe Perches <joe@...ches.com> wrote:

> if blocks that have a goto at the end of one branch can be
> simplified by reordering and unindenting.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  fs/dlm/plock.c | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/fs/dlm/plock.c b/fs/dlm/plock.c
> index e0ab3a9..3e0b6fc 100644
> --- a/fs/dlm/plock.c
> +++ b/fs/dlm/plock.c
> @@ -144,23 +144,23 @@ int dlm_posix_lock(dlm_lockspace_t *lockspace, u64 number, struct file *file,
>  
>  	send_op(op);
>  
> -	if (xop->callback == NULL) {
> -		rv = wait_event_killable(recv_wq, (op->done != 0));
> -		if (rv == -ERESTARTSYS) {
> -			log_debug(ls, "dlm_posix_lock: wait killed %llx",
> -				  (unsigned long long)number);
> -			spin_lock(&ops_lock);
> -			list_del(&op->list);
> -			spin_unlock(&ops_lock);
> -			kfree(xop);
> -			do_unlock_close(ls, number, file, fl);
> -			goto out;
> -		}
> -	} else {
> +	if (xop->callback) {
>  		rv = FILE_LOCK_DEFERRED;
>  		goto out;
>  	}
>  
> +	rv = wait_event_killable(recv_wq, (op->done != 0));
> +	if (rv == -ERESTARTSYS) {
> +		log_debug(ls, "dlm_posix_lock: wait killed %llx",
> +			  (unsigned long long)number);
> +		spin_lock(&ops_lock);
> +		list_del(&op->list);
> +		spin_unlock(&ops_lock);
> +		kfree(xop);
> +		do_unlock_close(ls, number, file, fl);
> +		goto out;
> +	}
> +
>  	spin_lock(&ops_lock);
>  	if (!list_empty(&op->list)) {
>  		log_error(ls, "dlm_posix_lock: op on list %llx",

Looks right.

Reviewed-by: Jeff Layton <jlayton@...chiereds.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/