linux-kernel - [PATCH] staging: Remove checkpatch errors in ion.c for android staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 23 Jul 2014 15:50:55 -0400
From:	Nicholas Krause <xerofoify@...il.com>
To:	gregkh@...uxfoundation.org
Cc:	john.stultz@...aro.org, rebecca@...roid.com, ccross@...roid.com,
	mitchelh@...eaurora.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] staging: Remove checkpatch errors in ion.c for android staging

This patch removes a few errors that checkpatch gives when run
on ion.c. I didn't remove the warning from returning in a void
function as we need to write ion_dma_buf_kunmap and I have no
idea how to do this as all we are doing in this function as of now
is returning and leaking the memory allocated in ion_dma_buf_kmap.

Signed-off-by: Nicholas Krause <xerofoify@...il.com>
---
 drivers/staging/android/ion/ion.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 389b8f6..934d55d 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -56,6 +56,7 @@ struct ion_device {
 	struct mutex buffer_lock;
 	struct rw_semaphore lock;
 	struct plist_head heaps;
+
 	long (*custom_ioctl)(struct ion_client *client, unsigned int cmd,
 			     unsigned long arg);
 	struct rb_root clients;
@@ -805,6 +806,7 @@ struct ion_client *ion_client_create(struct ion_device *dev,
 						client, &debug_client_fops);
 	if (!client->debug_root) {
 		char buf[256], *path;
+
 		path = dentry_path(dev->clients_debug_root, buf, 256);
 		pr_err("Failed to create client debugfs at %s/%s\n",
 			path, client->display_name);
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/