linux-kernel - Re: [PATCH] staging: Change kzalloc to kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Jul 2014 01:08:46 +0200
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	John Stultz <john.stultz@...aro.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Chen Gang <gang.chen.5i5j@...il.com>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	tomas.winkler@...el.com, devel@...verdev.osuosl.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 1:03 AM, Nicholas Krause <xerofoify@...il.com> wrote:
> This changes the call to kzalloc to kcalloc in ion_dummy_driver
> for allocating the heap.
>
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/staging/android/ion/ion_dummy_driver.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion_dummy_driver.c b/drivers/staging/android/ion/ion_dummy_driver.c
> index 3a45e79..8883432 100644
> --- a/drivers/staging/android/ion/ion_dummy_driver.c
> +++ b/drivers/staging/android/ion/ion_dummy_driver.c
> @@ -67,9 +67,8 @@ static int __init ion_dummy_init(void)
>  {
>         int i, err;
>
>         idev = ion_device_create(NULL);
> -       heaps = kzalloc(sizeof(struct ion_heap *) * dummy_ion_pdata.nr,
> -                       GFP_KERNEL);
> +       heaps = kcalloc(*dummy_ion_pdata.nr , sizeof((struct ion_heap *) *dummy_ion_pdata.nr) , GFP_KERNEL);

Nick, please go away.
Your patches are threat to Linux.

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/