linux-kernel - Re: [PATCH] perf: Check permission only for parent tracepoint event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bnsec3bn.wl%yarygin@linux.vnet.ibm.com>
Date:	Thu, 24 Jul 2014 17:07:56 +0400
From:	Alexander Yarygin <yarygin@...ux.vnet.ibm.com>
To:	Jiri Olsa <jolsa@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Alexander Yarygin <yarygin@...ux.vnet.ibm.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] perf: Check permission only for parent tracepoint event

At Wed, 16 Jul 2014 14:33:29 +0200,
Jiri Olsa wrote:
> 
> There's no need to check cloned event's permission once the
> parent was already checked.
> 
> Also the code is checking 'current' process permissions, which
> is not owner process for cloned events, thus could end up with
> wrong permission check result.
> 
> Reported-by: Alexander Yarygin <yarygin@...ux.vnet.ibm.com>
> Cc: Alexander Yarygin <yarygin@...ux.vnet.ibm.com>
> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
> Cc: Corey Ashford <cjashfor@...ux.vnet.ibm.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Link: http://lkml.kernel.org/r/1405079782-8139-1-git-send-email-jolsa@kernel.org
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  kernel/trace/trace_event_perf.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/kernel/trace/trace_event_perf.c b/kernel/trace/trace_event_perf.c
> index 5d12bb407b44..4b9c114ee9de 100644
> --- a/kernel/trace/trace_event_perf.c
> +++ b/kernel/trace/trace_event_perf.c
> @@ -30,6 +30,18 @@ static int perf_trace_event_perm(struct ftrace_event_call *tp_event,
>  			return ret;
>  	}
> 
> +	/*
> +	 * We checked and allowed to create parent,
> +	 * allow children without checking.
> +	 */
> +	if (p_event->parent)
> +		return 0;
> +
> +	/*
> +	 * It's ok to check current process (owner) permissions in here,
> +	 * because code below is called only via perf_event_open syscall.
> +	 */
> +
>  	/* The ftrace function trace is allowed only for root. */
>  	if (ftrace_event_is_function(tp_event)) {
>  		if (perf_paranoid_tracepoint_raw() && !capable(CAP_SYS_ADMIN))
> -- 
> 1.8.3.1
> 

Tested-by: Alexander Yarygin <yarygin@...ux.vnet.ibm.com>

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/