linux-kernel - Re: [PATCH] irq: Warn when shared interrupts do not match on NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140724141525.GK3935@laptop>
Date:	Thu, 24 Jul 2014 16:15:25 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	rjw@...ysocki.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irq: Warn when shared interrupts do not match on
 NO_SUSPEND

On Thu, Jul 24, 2014 at 03:46:38PM +0200, Thomas Gleixner wrote:
> On Thu, 24 Jul 2014, Peter Zijlstra wrote:
> 
> > Subject: irq: Warn when shared interrupts do not match on NO_SUSPEND
> > 
> > When suspend_device_irqs() iterates all descriptors, its pointless if
> > one has NO_SUSPEND set while another has not.
> > 
> > Validate on request_irq() that NO_SUSPEND state maches for SHARED
> > interrupts.
> 
> I'm happy to take that patch, but you are aware that it is going to
> break a few things?
> 
>   25:  ....   PCI-MSI-edge      aerdrv, PCIe PME

Better an obvious splat than non obvious misbehaviour in my book.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/