linux-kernel - Re: [PATCH 4/6] perf report: Honor column width setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Jul 2014 00:41:15 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/6] perf report: Honor column width setting

Hi guys,

On Thu, Jul 24, 2014 at 11:49 PM, Jiri Olsa <jolsa@...hat.com> wrote:
> On Thu, Jul 24, 2014 at 10:57:47AM -0300, Arnaldo Carvalho de Melo wrote:
>> Em Thu, Jul 24, 2014 at 02:57:51PM +0200, Jiri Olsa escreveu:
>> > On Wed, Jul 09, 2014 at 02:28:12PM +0900, Namhyung Kim wrote:
>> > > Set column width and do not change it if user gives -w/--column-widths
>> > > option.  It'll truncate longer symbols than the width if exists.
>> >
>> > SNIP
>> >
>> > > --- a/tools/perf/util/sort.c
>> > > +++ b/tools/perf/util/sort.c
>> > > @@ -70,7 +70,9 @@ static int hist_entry__thread_snprintf(struct hist_entry *he, char *bf,
>> > >                                  size_t size, unsigned int width)
>> > >  {
>> > >   const char *comm = thread__comm_str(he->thread);
>> > > - return repsep_snprintf(bf, size, "%-*s:%5d", width - 6,
>> > > +
>> > > + width = max(7U, width) - 6;
>> > > + return repsep_snprintf(bf, size, "%-*.*s:%5d", width, width,
>> > >                          comm ?: "", he->thread->tid);
>> > >  }
>> >
>> > also we now print out all sort headers left alligned, which is wrong for
>> > sort_thread header: "Command:  Pid' that mirrors value strings with ':'
>> > being aligned
>> >
>> > maybe something like in attached patch..?
>> >
>> > thanks,
>> > jirka
>> >
>> >
>> > ---
>> > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
>> > index f89714329c0f..fbbe86b7f63c 100644
>> > --- a/tools/perf/util/sort.c
>> > +++ b/tools/perf/util/sort.c
>> > @@ -78,6 +78,7 @@ static int hist_entry__thread_snprintf(struct hist_entry *he, char *bf,
>> >
>> >  struct sort_entry sort_thread = {
>> >     .se_header      = "Command:  Pid",
>> > +   .se_header_right= true,
>>
>> Is this just for the header? Perhaps its more clearly named .se_right_justify?
>
> yep, it's just for header.. let's see Namhyung might have better
> idea how to handle this problem

I think it still needs to be left-aligned.  So I'd rather change the
order - i.e. "Pid: Command".  Is it okay for you?

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/