linux-kernel - Re: [PATCH] staging: Change kzalloc to kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1xtx669002.fsf@unicorn.mansr.com>
Date:	Thu, 24 Jul 2014 17:47:57 +0100
From:	Måns Rullgård <mans@...sr.com>
To:	Nick Krause <xerofoify@...il.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	John Stultz <john.stultz@...aro.org>,
	paul.gortmaker@...driver.com, gang.chen.5i5j@...il.com,
	yongjun_wei@...ndmicro.com.cn,
	Dan Carpenter <dan.carpenter@...cle.com>,
	tomas.winkler@...el.com,
	"devel\@driverdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

Nick Krause <xerofoify@...il.com> writes:

> On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård <mans@...sr.com> wrote:
>> Nick Krause <xerofoify@...il.com> writes:
>>
>>> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård <mans@...sr.com> wrote:
>>>> Steven Rostedt <rostedt@...dmis.org> writes:
>>>>
>>>>> On Thu, 24 Jul 2014 10:47:25 -0400
>>>>> Steven Rostedt <rostedt@...dmis.org> wrote:
>>>>>
>>>>>> The three parameters are the number of elements, the size of each individual
>>>>>> element, and then finally the flags used on how to allocate that memory.
>>>>>> I have to say, you did get the flags part correct.
>>>>>>
>>>>>> Now lets look at what you did. For the size you had:
>>>>>
>>>>> That should have read "For the count you had:"
>>>>>
>>>>> Oh well, you get my point anyway.
>>>>
>>>> I have some doubts about the last bit.
>>>
>>> I am have this discussion with other kernel developers and just
>>> because I send out one patch as a newbie like this doesn't mean I
>>> don't known C.
>>
>> Now I no longer have doubts; I know for certain that the point didn't
>> get across.
>
> I get your point try other things but I talked to other kernel
> developers and most of them seemed to get this feedback to when they
> started.

Most kernel devs most certainly did NOT get started by spamming lkml
with unnecessary and incorrect patches despite being repeatedly told to
go away and stop wasting everybody's time.

-- 
Måns Rullgård
mans@...sr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/