linux-kernel - Re: Subject: [PATCH 1/1] mtd:nand:fix nand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140724165633.GF3711@ld-irv-0074>
Date:	Thu, 24 Jul 2014 09:56:33 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	"Gupta, Pekon" <pekon@...com>
Cc:	bpqw <bpqw@...ron.com>, "ron@...ian.org" <ron@...ian.org>,
	"artem.bityutskiy@...ux.intel.com" <artem.bityutskiy@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"b32955@...escale.com" <b32955@...escale.com>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"ezequiel.garcia@...e-electrons.com" 
	<ezequiel.garcia@...e-electrons.com>,
	"u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>
Subject: Re: Subject: [PATCH 1/1] mtd:nand:fix nand_lock/unlock() function

On Thu, Jul 24, 2014 at 07:54:41AM +0000, Pekon Gupta wrote:
> >On Thu, Jul 24, 2014 at 01:00:01AM +0000, bpqw wrote:
> >I don't see any in-tree users of nand_{un,}lock(). I recently caught a
> >bug in nand_lock() via inspection (still need to send a fix), but I was
> >considering dropping the functions entirely.
> >
> >I presume you have some out-of-tree driver that uses these functions,
> >then?
> >
> Please don't drop nand_{unlock, lock} interfaces at-least for sometime.
> I remember there were some users trying to use these for secure
> applications. But due to lack of proper userland utility support they
> probably dropped the idea.

OK, I won't drop them yet.

> Good to have this added as part of mtd-utils package, and then let it live
> for some more time.

As you note, there's no user-space support. There's actually no one
using them even in the kernel, which is why I considered dropping them.
If you want to use them, find a proper way to use them then! (I'm not
sure: do they match with mtd_lock() / ioctl(MEMLOCK) interface?)

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/