linux-kernel - Re: [PATCH] gpu: drm: omapdrm: Use %pad format for values of the dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1406225475.27221.59.camel@joe-AO725>
Date:	Thu, 24 Jul 2014 11:11:15 -0700
From:	Joe Perches <joe@...ches.com>
To:	matwey@....msu.ru
Cc:	airlied@...ux.ie, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, linux-omap@...r.kernel.org,
	matwey.kornilov@...il.com
Subject: Re: [PATCH] gpu: drm: omapdrm: Use %pad format for values of the
 dma_addr_t type

On Thu, 2014-07-24 at 21:58 +0400, matwey@....msu.ru wrote:
> The format change is to fix the following compilation issue:

Just a trivial note:

> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
[]
> @@ -791,7 +791,7 @@ int omap_gem_get_paddr(struct drm_gem_object *obj,
>  			omap_obj->paddr = tiler_ssptr(block);
>  			omap_obj->block = block;
>  
> -			DBG("got paddr: %08x", omap_obj->paddr);
> +			DBG("got paddr: %pad", &(omap_obj->paddr));

&foo->bar does not need parentheses.

Most uses in the kernel do not have them.
It seems to be ~25:1 without to with.

> @@ -985,9 +985,9 @@ void omap_gem_describe(struct drm_gem_object *obj, struct seq_file *m)
>  
>  	off = drm_vma_node_start(&obj->vma_node);
>  
> -	seq_printf(m, "%08x: %2d (%2d) %08llx %08Zx (%2d) %p %4d",
> +	seq_printf(m, "%08x: %2d (%2d) %08llx %pad (%2d) %p %4d",
>  			omap_obj->flags, obj->name, obj->refcount.refcount.counter,
> -			off, omap_obj->paddr, omap_obj->paddr_cnt,
> +			off, &(omap_obj->paddr), omap_obj->paddr_cnt,

etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/