linux-kernel - Re: [PATCH] staging: Change kzalloc to kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDOMVi7cHUAn_1AxJ+tN1c67UqBdLHLC1sJNSA=HUK-WzZCTA@mail.gmail.com>
Date:	Thu, 24 Jul 2014 14:41:53 -0400
From:	Nick Krause <xerofoify@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Harvey Harrison <harvey.harrison@...il.com>,
	Måns Rullgård <mans@...sr.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	John Stultz <john.stultz@...aro.org>,
	paul.gortmaker@...driver.com, gang.chen.5i5j@...il.com,
	yongjun_wei@...ndmicro.com.cn,
	Dan Carpenter <dan.carpenter@...cle.com>,
	tomas.winkler@...el.com,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 1:48 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Thu, 24 Jul 2014 10:30:51 -0700
> Harvey Harrison <harvey.harrison@...il.com> wrote:
>
>> On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt <rostedt@...dmis.org> wrote:
>> > On Thu, 24 Jul 2014 12:50:31 -0400
>> > Nick Krause <xerofoify@...il.com> wrote:
>>
>> >
>> >> I am have this discussion with other kernel developers and just
>> >> because I send out one patch as a newbie like this doesn't mean I
>> >> don't known C.
>> >
>> > It's not just one patch, and I didn't say you don't know C. I said you
>> > don't understand C enough for kernel development.
>>
>> And more importantly, stop guessing things are OK and selfishly asking
>> others to check
>> your work for you.
>>
>> If you have not at least _built_ the kernel with your change, and not
>> _run_ it, and not made
>> sure that the changed code is being _run_...you are wasting other people's time.
>>
>
> Nick,
>
> Just to bring Harvey's email here in perspective. I mentioned in my
> previous email that most of us are overworked. We don't have time to
> teach you if your patches are correct or not. By saying, "I'll just
> write the code and you tell me if it's correct, and test it for me" is
> like telling someone "Here's a lawn mower, now go mow my lawn".
>
> We like it if people put effort into their work and are confident
> themselves that they have the right code or not. There's enough
> reviewing of patches to do from people that put that effort in, that
> there's no time to review patches from people that don't know if their
> work or not.
>
> Cheers,
>
> -- Steve

Steve,
I have programming a lot in other areas just not the kernel.
You are right through I need to test my code better through.
Cheers Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/