linux-kernel - Re: [PATCH 4/6] perf report: Honor column width setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140724191436.GF7831@kernel.org>
Date:	Thu, 24 Jul 2014 16:14:36 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/6] perf report: Honor column width setting

Em Thu, Jul 24, 2014 at 05:58:44PM +0200, Jiri Olsa escreveu:
> On Fri, Jul 25, 2014 at 12:41:15AM +0900, Namhyung Kim wrote:
> > On Thu, Jul 24, 2014 at 11:49 PM, Jiri Olsa <jolsa@...hat.com> wrote:
> > > On Thu, Jul 24, 2014 at 10:57:47AM -0300, Arnaldo Carvalho de Melo wrote:
> > >> Em Thu, Jul 24, 2014 at 02:57:51PM +0200, Jiri Olsa escreveu:
> > >> >  struct sort_entry sort_thread = {
> > >> >     .se_header      = "Command:  Pid",
> > >> > +   .se_header_right= true,

> > >> Is this just for the header? Perhaps its more clearly named .se_right_justify?

> > > yep, it's just for header.. let's see Namhyung might have better
> > > idea how to handle this problem

> > I think it still needs to be left-aligned.  So I'd rather change the

Good, I like simpler fixes :)

> > order - i.e. "Pid: Command".  Is it okay for you?
 
> yes, jirka

Yes, its is more usual to have pid+command anyway, just run 'ps' :-)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/