[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <53D1973A.9060907@samsung.com>
Date: Fri, 25 Jul 2014 08:31:06 +0900
From: Kukjin Kim <kgene.kim@...sung.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
CC: linux-samsung-soc@...r.kernel.org,
Mark Rutland <mark.rutland@....com>,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Thomas Abraham <ta.omasab@...il.com>,
Tomasz Figa <t.figa@...sung.com>, linux-kernel@...r.kernel.org,
Kukjin Kim <kgene.kim@...sung.com>,
linux-arm-kernel@...ts.infradead.org,
Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v2] ARM: dts: add CPU nodes for Exynos4 SoCs
On 07/21/14 22:57, Bartlomiej Zolnierkiewicz wrote:
> Recent patch by Tomasz Figa ("irqchip: gic: Fix core ID calculation
> when topology is read from DT") fixed GIC driver to filter cluster ID
> from values returned by cpu_logical_map() for SoCs having registers
> mapped without per-CPU banking making it is possible to add CPU nodes
> for Exynos4 SoCs. In case of Exynos SoCs these CPU nodes are also
> required by future changes adding initialization of cpuidle states in
> Exynos cpuidle driver through DT.
>
> Tested on Origen board (Exynos4210 SoC) and Trats2 (Exynos4412 SoC).
>
> Signed-off-by: Bartlomiej Zolnierkiewicz<b.zolnierkie@...sung.com>
> ---
> Based on next-20140717 branch of linux-next tree +
> - [PATCH 2/6] ARM: EXYNOS: Fix core ID used by platsmp and hotplug code
> http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg32811.html
> - [PATCH] irqchip: gic: Fix core ID calculation when topology is read from DT
> http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg34277.html
>
> v2:
> - match the unit-address with the reg
>
> arch/arm/boot/dts/exynos4210.dtsi | 17 +++++++++++++++++
> arch/arm/boot/dts/exynos4212.dtsi | 17 +++++++++++++++++
> arch/arm/boot/dts/exynos4412.dtsi | 29 +++++++++++++++++++++++++++++
> 3 files changed, 63 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
> index ee3001f..bc2b444 100644
> --- a/arch/arm/boot/dts/exynos4210.dtsi
> +++ b/arch/arm/boot/dts/exynos4210.dtsi
> @@ -31,6 +31,23 @@
> pinctrl2 =&pinctrl_2;
> };
>
> + cpus {
> + #address-cells =<1>;
> + #size-cells =<0>;
> +
> + cpu@900 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a9";
> + reg =<0x900>;
> + };
> +
> + cpu@901 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a9";
> + reg =<0x901>;
> + };
> + };
> +
> sysram@...20000 {
> compatible = "mmio-sram";
> reg =<0x02020000 0x20000>;
> diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
> index 3c00e6e..dd0a43e 100644
> --- a/arch/arm/boot/dts/exynos4212.dtsi
> +++ b/arch/arm/boot/dts/exynos4212.dtsi
> @@ -22,6 +22,23 @@
> / {
> compatible = "samsung,exynos4212", "samsung,exynos4";
>
> + cpus {
> + #address-cells =<1>;
> + #size-cells =<0>;
> +
> + cpu@A00 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a9";
> + reg =<0xA00>;
> + };
> +
> + cpu@A01 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a9";
> + reg =<0xA01>;
> + };
> + };
> +
> combiner: interrupt-controller@...40000 {
> samsung,combiner-nr =<18>;
> };
> diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
> index c42a3e1..435a722 100644
> --- a/arch/arm/boot/dts/exynos4412.dtsi
> +++ b/arch/arm/boot/dts/exynos4412.dtsi
> @@ -22,6 +22,35 @@
> / {
> compatible = "samsung,exynos4412", "samsung,exynos4";
>
> + cpus {
> + #address-cells =<1>;
> + #size-cells =<0>;
> +
> + cpu@A00 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a9";
> + reg =<0xA00>;
> + };
> +
> + cpu@A01 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a9";
> + reg =<0xA01>;
> + };
> +
> + cpu@A02 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a9";
> + reg =<0xA02>;
> + };
> +
> + cpu@A03 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a9";
> + reg =<0xA03>;
> + };
> + };
> +
> combiner: interrupt-controller@...40000 {
> samsung,combiner-nr =<20>;
> };
OK, I'm fine on this, will apply.
Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists