lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <53D2189E.4030108@gmail.com> Date: Fri, 25 Jul 2014 14:13:10 +0530 From: Varka Bhadram <varkabhadram@...il.com> To: Nicolin Chen <Guangyu.Chen@...escale.com> CC: Nicolin Chen <nicoleotsuka@...il.com>, broonie@...nel.org, robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com, ijc+devicetree@...lion.org.uk, galak@...eaurora.org, rdunlap@...radead.org, lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.de, timur@...i.org, grant.likely@...aro.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, alsa-devel@...a-project.org, linuxppc-dev@...ts.ozlabs.org, shawn.guo@...aro.org, b02247@...escale.com, b42378@...escale.com, tklauser@...tanz.ch Subject: Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers On 07/25/2014 01:27 PM, Nicolin Chen wrote: > Hi Varka, > > Thank you for the comments! > > On Fri, Jul 25, 2014 at 01:05:05PM +0530, Varka Bhadram wrote: >> On 07/25/2014 12:49 PM, Nicolin Chen wrote: >> (...) >> >>> +static const struct platform_device_id fsl_asrc_devtype[] = { >>> + { >>> + .name = "imx35-asrc", >>> + .driver_data = IMX35_ASRC, >>> + }, { >>> + .name = "imx53-asrc", >>> + .driver_data = IMX53_ASRC, >>> + }, { >>> + /* sentinel */ >>> + } >>> +}; >>> +MODULE_DEVICE_TABLE(platform, fsl_asrc_devtype); >>> + >> where are you using fsl_asrc_devtype,,,? >> >>> +static const struct of_device_id fsl_asrc_ids[] = { >>> + { >>> + .compatible = "fsl,imx35-asrc", >>> + .data = &fsl_asrc_devtype[IMX35_ASRC], >> Ya here ... but what is the use...? > I got your point. I will drop all these and move ids behind probe/remove() > as you suggested at the first place and then use of_device_is_compatible() > inside the probe() instead. > >>> + asrc_priv->regmap = devm_regmap_init_mmio_clk(&pdev->dev, >>> + "mem", regs, &fsl_asrc_regmap_config); >> devm_regmap_init_mmio_clk(&pdev->dev, >> "mem", regs, >> &fsl_asrc_regmap_config); > I'll refine to > > devm_regmap_init_mmio_clk(&pdev->dev, "mem", regs, > &fsl_asrc_regmap_config); > >>> + if (IS_ERR(asrc_priv->regmap)) { >>> + dev_err(&pdev->dev, "failed to init regmap\n"); >>> + return PTR_ERR(asrc_priv->regmap); >>> + } >>> + >>> + irq = platform_get_irq(pdev, 0); >>> + if (irq < 0) { >>> + dev_err(&pdev->dev, "no irq for node %s\n", np->full_name); >>> + return irq; >>> + } >>> + >>> + ret = devm_request_irq(&pdev->dev, irq, fsl_asrc_isr, 0, >>> + asrc_priv->name, asrc_priv); >> same... > Sorry I don't see any problem with this devm_request_irq()... Ohhh... This is the problem with my email client... Sorry... Thanks... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists