linux-kernel - Re: [PATCH] NFC: st21nfca: Remove double assignment of .owner in struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140725111314.0578f122@toffy-MacBookPro>
Date:	Fri, 25 Jul 2014 11:13:14 +0200
From:	Christophe RICARD <christophe.ricard@...il.com>
To:	Emil Goode <emilgoode@...il.com>
Cc:	Lauro Ramos Venancio <lauro.venancio@...nbossa.org>,
	Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-wireless@...r.kernel.org, linux-nfc@...ts.01.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] NFC: st21nfca: Remove double assignment of .owner in
 struct device_driver

On Mon,  2 Jun 2014 16:21:00 +0200
Emil Goode <emilgoode@...il.com> wrote:

> The .owner member of struct device_driver is assigned THIS_MODULE
> twice.
> 
> Introduced by:
> 
> commit c44cb2edd01ca31471d9385f0895891b006ab904
> ("NFC: dts: st21nfca: Add device-tree (Open Firmware) support to
> st21nfca")
> 
> Signed-off-by: Emil Goode <emilgoode@...il.com>
> ---
>  drivers/nfc/st21nfca/i2c.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c
> index 3f954ed..95942ca 100644
> --- a/drivers/nfc/st21nfca/i2c.c
> +++ b/drivers/nfc/st21nfca/i2c.c
> @@ -710,7 +710,6 @@ static struct i2c_driver st21nfca_hci_i2c_driver
> = { .driver = {
>  		.owner = THIS_MODULE,
>  		.name = ST21NFCA_HCI_I2C_DRIVER_NAME,
> -		.owner = THIS_MODULE,
>  		.of_match_table =
> of_match_ptr(of_st21nfca_i2c_match), },
>  	.probe = st21nfca_hci_i2c_probe,

Acked-by: Christophe RICARD <christophe-h.ricard@...com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/