linux-kernel - Re: [PATCH 1/3] staging: dgng: Fix Macros with complex values should be enclosed in parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140725104932.GW25880@mwanda>
Date:	Fri, 25 Jul 2014 13:49:32 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Seunghun Lee <waydi1@...il.com>
Cc:	gregkh@...uxfoundation.org, lidza.louina@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: dgng: Fix Macros with complex values should
 be enclosed in parenthesis

On Fri, Jul 25, 2014 at 12:26:51AM +0900, Seunghun Lee wrote:
> This patch fixes a checkpatch errors
> "Macros with complex values should be enclosed in parenthesis"
> 
> Signed-off-by: Seunghun Lee <waydi1@...il.com>
> ---
>  drivers/staging/dgnc/dgnc_driver.h |   40 ++++++++++++------------
>  drivers/staging/dgnc/digi.h        |   60 ++++++++++++++++++------------------
>  drivers/staging/dgnc/dpacompat.h   |   12 ++++----
>  3 files changed, 56 insertions(+), 56 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index fe5ea90..f7730a1 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -111,32 +111,32 @@
>  #endif
>  
>  #if defined TRC_TO_KMEM
> -#define PRINTF_TO_KMEM(args) dgnc_tracef args
> +#define PRINTF_TO_KMEM(args) do { dgnc_tracef args } while (0)

This is *so* nasty...  I suspect the only reason it works is because
TRC_TO_KMEM is never defined.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/