lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 25 Jul 2014 13:22:49 +0100
From:	Mel Gorman <>
To:	Vlastimil Babka <>
Cc:, Andrew Morton <>,
	David Rientjes <>,, Minchan Kim <>,
	Joonsoo Kim <>,
	Michal Nazarewicz <>,
	Naoya Horiguchi <>,
	Christoph Lameter <>,
	Rik van Riel <>,
	Zhang Yanfei <>
Subject: Re: [PATCH V4 03/15] mm, compaction: do not count compact_stall if
 all zones skipped compaction

On Wed, Jul 16, 2014 at 03:48:11PM +0200, Vlastimil Babka wrote:
> The compact_stall vmstat counter counts the number of allocations stalled by
> direct compaction. It does not count when all attempted zones had deferred
> compaction, but it does count when all zones skipped compaction. The skipping
> is decided based on very early check of compaction_suitable(), based on
> watermarks and memory fragmentation. Therefore it makes sense not to count
> skipped compactions as stalls. Moreover, compact_success or compact_fail is
> also already not being counted when compaction was skipped, so this patch
> changes the compact_stall counting to match the other two.
> Additionally, restructure __alloc_pages_direct_compact() code for better
> readability.
> Signed-off-by: Vlastimil Babka <>
> Cc: Minchan Kim <>
> Cc: Mel Gorman <>
> Cc: Joonsoo Kim <>
> Cc: Michal Nazarewicz <>
> Cc: Naoya Horiguchi <>
> Cc: Christoph Lameter <>
> Cc: Rik van Riel <>
> Cc: David Rientjes <>

Acked-by: Mel Gorman <>

Mel Gorman
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists