linux-kernel - Re: [can-next PATCH 1/1] net: can: c_can_platform: Use devm_ioremap instead of devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53D2563B.1090703@pengutronix.de>
Date:	Fri, 25 Jul 2014 15:06:03 +0200
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Wolfram Sang <wsa@...g-engineering.com>,
	Mugunthan V N <mugunthanvnm@...com>
CC:	Wolfgang Grandegger <wg@...ndegger.com>,
	Pavel Machek <pavel@...x.de>, Thor Thayer <tthayer@...era.com>,
	Prabhakar Lad <prabhakar.csengg@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Chen Gang <gang.chen@...anux.com>,
	George Cherian <george.cherian@...com>,
	linux-can@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [can-next PATCH 1/1] net: can: c_can_platform: Use devm_ioremap
 instead of devm_ioremap_resource.

On 07/25/2014 12:49 PM, Wolfram Sang wrote:
> Am 25-07-2014 08:19, schrieb Mugunthan V N:
>> From: George Cherian <george.cherian@...com>
>>
>> The raminit register is shared register for both can0 and can1.
>> Using devm_ioremap_resource fails the mapping for can1 interface
>> leading to a non functional can interface.
>>
>> Signed-off-by: George Cherian <george.cherian@...com>
>> Signed-off-by: Mugunthan V N <mugunthanvnm@...com>
> 
> The patch is a hack, or? It simply works because we drop all sanity
> checking on the resource.

Well, thinking about it, yes, a bit.

> I am on holiday and can't really check, yet I believe the AM335x has
> devicetree support for accessing single bits in SYSCONF. This is what
> needs to be applied here, too, AFAICT.

I cannot find any generic driver for the sysconf, USB and Ethernet have
an extra driver for their shared register space. I think the d_can can
access the raminit register via a syscon driver.

Enjoy your holiday :)
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (243 bytes)