linux-kernel - Re: [PATCH v2 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140725020520.GA29136@MrMyself>
Date:	Fri, 25 Jul 2014 10:05:22 +0800
From:	Nicolin Chen <Guangyu.Chen@...escale.com>
To:	Tobias Klauser <tklauser@...tanz.ch>
CC:	Nicolin Chen <nicoleotsuka@...il.com>, <broonie@...nel.org>,
	<shawn.guo@...aro.org>, <robh+dt@...nel.org>, <pawel.moll@....com>,
	<mark.rutland@....com>, <ijc+devicetree@...lion.org.uk>,
	<galak@...eaurora.org>, <rdunlap@...radead.org>,
	<lgirdwood@...il.com>, <perex@...ex.cz>, <tiwai@...e.de>,
	<timur@...i.org>, <grant.likely@...aro.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<alsa-devel@...a-project.org>, <linuxppc-dev@...ts.ozlabs.org>,
	<b02247@...escale.com>, <b42378@...escale.com>
Subject: Re: [PATCH v2 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and
 platform drivers

Hi Tobias,

On Thu, Jul 24, 2014 at 05:20:45PM +0200, Tobias Klauser wrote:
> On 2014-07-24 at 10:35:29 +0200, Nicolin Chen <nicoleotsuka@...il.com> wrote:
> > The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of a
> > signal associated with an input clock into a signal associated with a different
> > output clock. The driver currently works as a Front End of DPCM with other Back
> > Ends DAI links such as ESAI<->CS42888 and SSI<->WM8962 and SAI. It converts the
> > original sample rate to a common rate supported by Back Ends for playback while
> > converts the common rate of Back Ends to a desired rate for capture. It has 3
> > pairs to support three different substreams within totally 10 channels.
> > 
> > Signed-off-by: Nicolin Chen <nicoleotsuka@...il.com>
> > ---
> 
> [...]
> 
> > --- /dev/null
> > +++ b/sound/soc/fsl/fsl_asrc.c
> > @@ -0,0 +1,1031 @@
> 
> [...]
> 
> > +static struct platform_driver fsl_asrc_driver = {
> > +	.probe = fsl_asrc_probe,
> > +	.driver = {
> > +		.name = "fsl-asrc",
> > +		.owner = THIS_MODULE,
> 
> Not necessary, this will be set by module_platform_driver (or
> the expansion of platform_driver_register, respectively).
> 
> > +		.of_match_table = fsl_asrc_ids,
> > +		.pm = &fsl_asrc_pm,
> > +	},
> > +};
> > +module_platform_driver(fsl_asrc_driver);
> 
> [...]
> 
> > --- /dev/null
> > +++ b/sound/soc/fsl/fsl_asrc_dma.c
> > @@ -0,0 +1,384 @@
> 
> [...]
> 
> > +static int fsl_asrc_dma_pcm_new(struct snd_soc_pcm_runtime *rtd)
> > +{
> > +	struct snd_card *card = rtd->card->snd_card;
> > +	struct snd_pcm_substream *substream;
> > +	struct snd_pcm *pcm = rtd->pcm;
> > +	u64 dma_mask = DMA_BIT_MASK(32);
> > +	int ret, i;
> > +
> > +	if (!card->dev->dma_mask)
> > +		card->dev->dma_mask = &dma_mask;
> 
> dma_mask will go out of scope after fsl_asrc_dma_pcm_new returns,
> resulting in a stray pointer in card->dev->dma_mask.

Will fix them in v3.

Thank you
Nicolin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/