| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Jul 2014 10:25:10 +0800 From: Chao Yu <chao2.yu@...sung.com> To: anton@...era.com Cc: linux-ntfs-dev@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: [PATCH] ntfs: avoid incorrectly release for root inode in fill_super In d_make_root, when we fail to allocate dentry for root inode, we will iput root inode in this function. So we do not need to release this inode again at d_make_root's caller. Signed-off-by: Chao Yu <chao2.yu@...sung.com> --- fs/ntfs/super.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c index 6c3296e..99c5cc6 100644 --- a/fs/ntfs/super.c +++ b/fs/ntfs/super.c @@ -2975,7 +2975,11 @@ static int ntfs_fill_super(struct super_block *sb, void *opt, const int silent) vol->secure_ino = NULL; } } - iput(vol->root_ino); + + /* + * Just set NULL value here because we have already iput root_ino + * in d_make_root. + */ vol->root_ino = NULL; iput(vol->lcnbmp_ino); vol->lcnbmp_ino = NULL; -- 2.0.1.474.g72c7794 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists