lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Fri, 25 Jul 2014 09:27:35 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	mingo@...hat.com, peterz@...radead.org
Cc:	Mark Rustad <mark.d.rustad@...el.com>,
	linux-kernel@...r.kernel.org,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: [PATCH] sched: Resolve some shadow warnings

From: Mark Rustad <mark.d.rustad@...el.com>

Using names like down and up, which are well-known semaphore
functions, makes those functions unavailable. This can be a
trap for the future, should there be reason to call down or
up here. Mostly it is just noise, so make it go away by using
other names.

Signed-off-by: Mark Rustad <mark.d.rustad@...el.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
---
 kernel/sched/sched.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 579712f..a5f0f42 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -253,17 +253,17 @@ struct task_group {
 typedef int (*tg_visitor)(struct task_group *, void *);
 
 extern int walk_tg_tree_from(struct task_group *from,
-			     tg_visitor down, tg_visitor up, void *data);
+			     tg_visitor in, tg_visitor out, void *data);
 
 /*
- * Iterate the full tree, calling @down when first entering a node and @up when
+ * Iterate the full tree, calling @in when first entering a node and @out when
  * leaving it for the final time.
  *
  * Caller must hold rcu_lock or sufficient equivalent.
  */
-static inline int walk_tg_tree(tg_visitor down, tg_visitor up, void *data)
+static inline int walk_tg_tree(tg_visitor in, tg_visitor out, void *data)
 {
-	return walk_tg_tree_from(&root_task_group, down, up, data);
+	return walk_tg_tree_from(&root_task_group, in, out, data);
 }
 
 extern int tg_nop(struct task_group *tg, void *data);
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists