lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CACVXFVOv1TShu=s40KvVLMTfk4b2ktZ0xmDUPyiO+7=BqOcSrw@mail.gmail.com> Date: Fri, 25 Jul 2014 11:13:16 +0800 From: Ming Lei <tom.leiming@...il.com> To: Jeff Moyer <jmoyer@...hat.com> Cc: Gu Zheng <guz.fnst@...fujitsu.com>, Benjamin LaHaise <bcrl@...ck.org>, Jens Axboe <axboe@...nel.dk>, Andrew Morton <akpm@...ux-foundation.org>, "open list:AIO" <linux-aio@...ck.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/4] aio: use the macro rather than the inline magic number On Tue, Jul 22, 2014 at 9:54 PM, Jeff Moyer <jmoyer@...hat.com> wrote: > Gu Zheng <guz.fnst@...fujitsu.com> writes: > >> Signed-off-by: Gu Zheng <guz.fnst@...fujitsu.com> > > Reviewed-by: Jeff Moyer <jmoyer@...hat.com> > >> --- >> fs/aio.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/fs/aio.c b/fs/aio.c >> index ad35876..1dc6158 100644 >> --- a/fs/aio.c >> +++ b/fs/aio.c >> @@ -201,7 +201,7 @@ static struct dentry *aio_mount(struct file_system_type *fs_type, >> static const struct dentry_operations ops = { >> .d_dname = simple_dname, >> }; >> - return mount_pseudo(fs_type, "aio:", NULL, &ops, 0xa10a10a1); >> + return mount_pseudo(fs_type, "aio:", NULL, &ops, AIO_RING_MAGIC); IMO, it might be better to use a new macro like AIO_FS_MAGIC with same number here because the same magic number 0xa10a10a1 serves for two purposes. Thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists