linux-kernel - Re: [Cluster-devel] [RFC PATCH 1/5] fs: xstat system call VFS bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <669415318.13475310.1406312276453.JavaMail.zimbra@redhat.com>
Date:	Fri, 25 Jul 2014 14:17:56 -0400 (EDT)
From:	Bob Peterson <rpeterso@...hat.com>
To:	Abhi Das <adas@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	cluster-devel@...hat.com
Subject: Re: [Cluster-devel] [RFC PATCH 1/5] fs: xstat system call VFS bits

----- Original Message -----
> This patch adds the VFS bits of the xstat patchset by David
> Howells. The xgetdents syscall uses this to obtain stat
> information for directory entries.
> 
> Signed-off-by: Abhi Das <adas@...hat.com>
> ---
>  arch/x86/syscalls/syscall_32.tbl |   2 +
>  arch/x86/syscalls/syscall_64.tbl |   2 +
>  fs/stat.c                        | 338
>  ++++++++++++++++++++++++++++++++++++---
>  include/linux/fs.h               |   4 +
>  include/linux/stat.h             |  14 +-
>  include/linux/syscalls.h         |   5 +
>  include/uapi/linux/fcntl.h       |   1 +
>  include/uapi/linux/stat.h        | 110 +++++++++++++
>  8 files changed, 453 insertions(+), 23 deletions(-)
(snip)
> +static int xstat_get_params(unsigned int mask, struct xstat __user *buffer,
> +			    struct kstat *stat)
> +{
> +	memset(stat, 0xde, sizeof(*stat)); // DEBUGGING

Did you forget to remove this DEBUGGING statement? In either case, the c++
comment should be /* */.

Regards,

Bob Peterson
Red Hat File Systems
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/