linux-kernel - Re: [PATCH] Input: wacom_serial4 - prepare for wacom USB moving to HID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53D2AAB4.1090109@redhat.com>
Date:	Fri, 25 Jul 2014 21:06:28 +0200
From:	Hans de Goede <hdegoede@...hat.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Julian Squires <julian@...ht.net>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>
CC:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: wacom_serial4 - prepare for wacom USB moving to
 HID

Hi,

On 07/24/2014 10:31 PM, Dmitry Torokhov wrote:
> wacom_wac.h will be moving to drivers/hid. Since we only need 3 definitions
> from it let's simply copy them over.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Ack, but you will want to drop the #include of wacom_wac.h yoo.

Regards,

Hans

> ---
>  drivers/input/tablet/wacom_serial4.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/input/tablet/wacom_serial4.c b/drivers/input/tablet/wacom_serial4.c
> index d3d251e..deef50e 100644
> --- a/drivers/input/tablet/wacom_serial4.c
> +++ b/drivers/input/tablet/wacom_serial4.c
> @@ -149,6 +149,11 @@ MODULE_LICENSE("GPL");
>  #define F_HAS_STYLUS2		0x02
>  #define F_HAS_SCROLLWHEEL	0x04
>  
> +/* device IDs */
> +#define STYLUS_DEVICE_ID	0x02
> +#define CURSOR_DEVICE_ID	0x06
> +#define ERASER_DEVICE_ID	0x0A
> +
>  enum { STYLUS = 1, ERASER, CURSOR };
>  
>  static const struct {
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/