linux-kernel - Re: [PATCH v2] Input: add i2c/smbus driver for elan touchpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140725200656.GA2827@core.coreip.homeip.net>
Date:	Fri, 25 Jul 2014 13:06:56 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	cheng wei Lin <dusonlin@....com.tw>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	bleung@...omium.org, agnescheng@...omium.org,
	"SRD1 &#65533;蝬踐&#65533;&#65533;?都&#65533;&#65533;&#65533;&#65533;" 
	<phoenix@....com.tw>, jeff.chuang@....com.tw
Subject: Re: [PATCH v2] Input: add i2c/smbus driver for elan touchpad

On Fri, Jul 25, 2014 at 11:20:53AM -0700, Dmitry Torokhov wrote:
> Hi Duson,
> 
> On Sat, Jul 26, 2014 at 02:05:02AM +0800, cheng wei Lin wrote:
> > Hi Dmitry,
> > 
> > Sorry for late to reply you and thanks for your command
> > 
> > Yes, I also agree, it looks great than my original code.
> 
> Thank you for confirming.
> 
> > So, should I modify this and upstream v3 patch for you?
> 
> No, that is fine, I'll fix it up on my end.

Hmm, I am also looking at elan_get_x_resolution() and in case of SMB
we'll never get negative result since we are doing
"elan_convert_res(val[1] & 0x0F)". Was it intended as such, or do we
need to extend sign here via

	(((char)(val[1] & 0x0F)) << 4) >> 4;

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/