linux-kernel - Re: [PATCH] iio: hid-sensor-magn-3d: Fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+BWVUQVpXZ50XMFhRBooff2573EnHn22E2ebofbKfEjch7gqw@mail.gmail.com>
Date:	Fri, 25 Jul 2014 16:02:22 -0500
From:	Reyad Attiyat <reyad.attiyat@...il.com>
To:	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc:	Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: hid-sensor-magn-3d: Fix build warning

Whoops looks like I typed an extra character, sorry should have caught this.
Thanks Sirinivas will resend.

On Fri, Jul 25, 2014 at 2:52 PM, Srinivas Pandruvada
<srinivas.pandruvada@...ux.intel.com> wrote:
> On 07/25/2014 12:32 PM, Reyad Attiyat wrote:
>>
>> Fix build warning, sizeof() called on dynamically
>> sized pointer, by removing the call and the dependent
>> function parameter. It is not needed or used in this
>> driver, when pushing values to an iio buffer.
>>
>> Signed-off-by: Reyad Attiyat <reyad.attiyat@...il.com>
>> ---
>>   drivers/iio/magnetometer/hid-sensor-magn-3d.c | 7 ++-----
>>   1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
>> b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
>> index 3ec777a..915ffb9 100644
>> --- a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
>> +++ b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
>> @@ -246,8 +246,7 @@ static const struct iio_info magn_3d_info = {
>>   };
>>
>>   /* Function to push data to buffer */
>> -static void hid_sensor_push_data(struct iio_dev *indio_dev, const void
>> *data,
>> -       int len)
>> +static void hid_sensor_push_data(struct iio_dev *indio_dev, const void
>> *data)
>>   {
>>         dev_dbg(&indio_dev->dev, "hid_sensor_push_data\n");
>>         iio_push_to_buffers(indio_dev, data);
>> @@ -263,9 +262,7 @@ static int magn_3d_proc_event(struct
>> hid_sensor_hub_device *hsdev,
>>
>>         dev_dbg(&indio_dev->dev, "magn_3d_proc_event\n");
>>         if (atomic_read(&magn_state->common_attributes.data_ready))
>> -               hid_sensor_push_data(indio_dev,
>> -                               magn_state->iio_vals,
>> -                               sizeof(magn_state->iio_vals));
>> +               hid_sensor_push_data(indio_devm, magn_state->iio_vals);
>
> Is it indio_devm,  not indio_dev?
>
> Thanks,
> Srinivas
>>
>>
>>         return 0;
>>   }
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/